Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Use operator in deploying to google #73

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat!: Use operator in deploying to google #73

wants to merge 15 commits into from

Conversation

jsbroks
Copy link
Member

@jsbroks jsbroks commented Jul 20, 2023

No description provided.

@jsbroks jsbroks requested a review from a team July 20, 2023 20:02
@jsbroks jsbroks requested a review from a team as a code owner July 20, 2023 20:02
@jsbroks jsbroks requested a review from gls4 as a code owner August 28, 2023 21:56
gls4
gls4 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@gls4 gls4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Nice job re-packaging the load balancer stuff. The only thing I will say is that we might want to upgrade the kubernetes provider to 1.20 before hand -- we've run into problems other places when terraform hasn't updated it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gls4 gls4 gls4 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsbroks @gls4 @zacharyblasczyk