Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(weave): Add gpt-4.5-preview and deepseek to playground #3830

Merged
merged 6 commits into from
Mar 4, 2025

Conversation

jwlee64
Copy link
Contributor

@jwlee64 jwlee64 commented Mar 3, 2025

Description

Screenshot 2025-03-03 at 3 58 15 PM Screenshot 2025-03-03 at 4 04 17 PM

Testing

How was this PR tested?

Summary by CodeRabbit

  • New Features
    • Expanded AI model support with new selections from OpenAI, DeepSeek, Azure, Anthropic, and Bedrock, offering enhanced function calling and improved token limits.
    • Updated provider configurations ensure streamlined integration and seamless use of these advanced AI options in the application.

@jwlee64 jwlee64 requested review from a team as code owners March 3, 2025 23:59
Copy link
Contributor

coderabbitai bot commented Mar 4, 2025

Walkthrough

This pull request expands model configuration support by updating multiple files. It adds new token limit entries and provider details for GPT-4.5 and DeepSeek models in a TypeScript configuration file, augments a JSON configuration with several new model provider entries (including for Azure AI, Anthropic, and Bedrock), and updates a Python mapping for DeepSeek to include its API key. Additionally, one existing provider entry is modified to reflect a new mapping requirement.

Changes

File(s) Change Summary
weave-js/.../llmMaxTokens.ts Added new entries for "gpt-4.5-preview", "gpt-4.5-preview-2025-02-27", "deepseek/deepseek-reasoner", and "deepseek/deepseek-chat" to LLM_MAX_TOKENS; updated LLM_PROVIDERS and LLM_PROVIDER_LABELS with DeepSeek.
weave/trace_server/.../model_providers.json Introduced multiple new entries for providers: OpenAI (GPT-4.5), Azure AI, DeepSeek, Anthropic, and Bedrock; modified one Anthropic entry's provider from "bedrock" to "bedrock_converse".
weave/trace_server/.../model_providers.py Added "deepseek": "DEEPSEEK_API_KEY" to the PROVIDER_TO_API_KEY_NAME_MAP dictionary.

Possibly related PRs

Suggested reviewers

  • jamie-rasmussen
  • tssweeney

Poem

I'm a rabbit with a techy beat,
Hopping through codes, oh so neat.
New tokens and models join my den,
Configs and keys now flow like zen.
With every line a joyful leap,
Celebrating changes in a burrow so deep!
🐇💻

✨ Finishing Touches
  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jwlee64 jwlee64 changed the title chore(weave): Add deepseek to playground chore(weave): Add gpt-4.5-preview and deepseek to playground Mar 4, 2025
@@ -107,6 +107,15 @@ export const LLM_MAX_TOKENS = {
max_tokens: 100000,
supports_function_calling: true,
},
'gpt-4.5-preview': {
litellm_provider: 'openai',
api_key_name: 'OPENAI_API_KEY',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this need an api key name but the others dont?

"anthropic.claude-3-5-sonnet-20240620-v1:0": {
"litellm_provider": "bedrock",
"api_key_name": "BEDROCK_API_KEY"
},
"anthropic.claude-3-7-sonnet-20250219-v1:0": {
"litellm_provider": "bedrock",
"litellm_provider": "bedrock_converse",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, why?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new format?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm this was auto exported but let me just double check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought i made a merge error, but I guess thats what its suppposed to be, shouldnt matter since we dont expose 3-7 under bedrock in the frontend yet

@jwlee64 jwlee64 merged commit 3dffee0 into master Mar 4, 2025
133 checks passed
@jwlee64 jwlee64 deleted the add-deepseek branch March 4, 2025 18:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants