Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for the PositionWatcher thread to stop #1109

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Wait for the PositionWatcher thread to stop #1109

wants to merge 12 commits into from

Conversation

aronbierbaum
Copy link
Contributor

Without this change closing a AVPlayer might crash because the PositionWatcher thread has not stopped before the AVPlayer is destroyed.

@mrgreywater
Copy link

a simple watcher.wait() will do the same as your loop

@aronbierbaum aronbierbaum force-pushed the wait_directsound_thread branch from 58eccea to d45f6ae Compare September 11, 2019 03:45
@aronbierbaum aronbierbaum force-pushed the wait_directsound_thread branch from d45f6ae to 59b8bc8 Compare February 7, 2021 16:23
@aronbierbaum aronbierbaum force-pushed the wait_directsound_thread branch from 59b8bc8 to b46e8a2 Compare June 15, 2022 15:34
@aronbierbaum aronbierbaum force-pushed the wait_directsound_thread branch from b46e8a2 to 705ad03 Compare June 15, 2022 18:38
@aronbierbaum aronbierbaum force-pushed the wait_directsound_thread branch from d63024f to 7f99878 Compare October 3, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aronbierbaum @mrgreywater