Add support for a join Semilattice #14
Open
+101
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fn identity(&self) -> Self; | ||
| } | ||
|
|
||
| pub trait JoinSemiLattice: Join {} |
There was a problem hiding this comment.
You might look at a blanket implementation here when the traits are satisfied.
There was a problem hiding this comment.
impl<T: Join> JoinSemiLattice for T {}
Like this? (For all types T)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently supports following properties:
Implemented an example with tests. This example implements a set (which uses union).
Future improvements:
This example could be extended in the future to implement a merge semilattice, which uses intersection for the join. And combine them into a full lattice