Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: made some changes and fixes #27

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

TazmanianDI
Copy link
Contributor

  • Added support for the "userDefinedResponse" event added in web chat 8.2.0.
  • Fixed an order bug that can occur if a user defined response is fired during the render process in some cases. This meant reworking the portals container interface which was a breaking change and we decided to just remove it from the public API.
  • Added support for usages on cp4d so the library will properly calculate the endpoints for the web chat entry script.
  • Removed the deprecated withWebChat hook.

Copy link
Member

@ethanwinters ethanwinters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but the commit message needs to be updated to be able to push out a new major release. Might be wise to not merge until I am back from vacation since this is our first major release with this toolchain.

BREAKING CHANGE: Removed the deprecated withWebChat hook.
BREAKING CHANGE: Renamed the "renderCustomResponse" prop to "renderUserDefinedResponse".
BREAKING CHANGE: Removed the CustomResponsePortalsContainer component.

- Added support for the "userDefinedResponse" event added in web chat 8.2.0.
- Fixed an order bug that can occur if a user defined response is fired during the render process
  in some cases. This meant reworking the portals container interface which was a breaking change
  and we decided to just remove it from the public API.
- Added support for usages on cp4d so the library will properly calculate the endpoints for the
  web chat entry script.
@TazmanianDI TazmanianDI force-pushed the user-defined-response branch from 8609f0c to c4d2309 Compare July 12, 2024 13:20
@TazmanianDI TazmanianDI merged commit 182d185 into main Jul 12, 2024
3 checks passed
@TazmanianDI TazmanianDI deleted the user-defined-response branch July 12, 2024 13:23
watson-github-bot pushed a commit that referenced this pull request Jul 17, 2024
# [2.0.0](v1.1.1...v2.0.0) (2024-07-17)

### Bug Fixes

* made some changes and fixes ([#27](#27)) ([182d185](182d185))
* made some changes to fix custom elements not being sized correctly ([#28](#28)) ([13ef8f7](13ef8f7))

### BREAKING CHANGES

* Classnames and styles are now injected by default when using WebChatCustomElement.
* Removed the deprecated withWebChat hook.
* Renamed the "renderCustomResponse" prop to "renderUserDefinedResponse".
* Removed the CustomResponsePortalsContainer component.

- Added support for the "userDefinedResponse" event added in web chat 8.2.0.
- Fixed an order bug that can occur if a user defined response is fired during the render process
  in some cases. This meant reworking the portals container interface which was a breaking change
  and we decided to just remove it from the public API.
- Added support for usages on cp4d so the library will properly calculate the endpoints for the
  web chat entry script.
@watson-github-bot
Copy link
Member

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants