Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Measurement container performance scales poorly #227

Open
leokoppel opened this issue Oct 23, 2017 · 1 comment
Open

Measurement container performance scales poorly #227

leokoppel opened this issue Oct 23, 2017 · 1 comment
Assignees
@leokoppel
Labels
enhancement

Comments

@leokoppel
Copy link
Contributor

An informal report from @navganti

Platform

xenial 64

Steps to Reproduce

  1. Add items to landmark measurement containers

Observed result

Operations become noticeably slow unless old items are deleted from the container.

Should add a benchmark first to determine which operations are slow, then determine how to fix.
@leokoppel leokoppel self-assigned this Oct 23, 2017
@leokoppel leokoppel mentioned this issue Oct 26, 2017
Merged
4 tasks
@leokoppel
Copy link
Contributor Author

The benchmarks in #228 reveal MeasurementContainer::get() is terribly inefficient: O(NlogN) instead of expected O(logN).

@leokoppel leokoppel mentioned this issue Oct 26, 2017
Merged
4 tasks
leokoppel added a commit that referenced this issue Oct 29, 2017
@leokoppel
Add benchmarks to MeasurementContainer (#228)
b9e7301 
Part of #227

- Add CMake helpers to add benchmarks using Google's benchmark library
- Add benchmarks investigate MeasurementContainer performance (empalce() and get())
- To build them, you must install benchmark, then build libwave with cmake .. -DBUILD_BENCHMARKS=ON.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leokoppel leokoppel

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leokoppel