Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce wave_utils dependencies #234

Open
leokoppel opened this issue Oct 30, 2017 · 0 comments
Open

Reduce wave_utils dependencies #234

leokoppel opened this issue Oct 30, 2017 · 0 comments
Assignees

Comments

@leokoppel
Copy link
Contributor

leokoppel commented Oct 30, 2017

#231 allows partial build without all the dependencies, but wave_utils is still needed by most modules and requires opencv.

Current behaviour

  • wave_utils depends on opencv, just to allow reading into cv::Mat from a yaml file.
  • wave_utils contains wave_test.hpp, used by libwave unit tests

Expected behaviour

  • wave_utils should not depend on opencv

    • Per CMake: allow partial build and finding components #231, we want to allow building subsets of libwave without needing all dependencies, or just to reduce build time and size.
    • Almost all modules depend on wave_utils, even ones having nothing to do with opencv
    • It seems like bad form to demand a huge dependency for a single use of cv::Mat, not useful on its own
    • We will probably add parser functions for other external classes in future, and should have a way to add them to their own modules anyway
  • wave_test.hpp should not be in wave_utils

    • It is not part of public interface - the functions in wave_test should not be installed for users of libwave
@leokoppel leokoppel self-assigned this Oct 30, 2017
leokoppel added a commit that referenced this issue Nov 1, 2017
Part of #234 

- Remove wave_utils dependency on OpenCV
- Move the cv::Mat parser to wave_vision 
- (tacking on) request correct Ceres version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant