Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building wave_matching without visualization #245

Open
leokoppel opened this issue Nov 7, 2017 · 0 comments
Open

Allow building wave_matching without visualization #245

leokoppel opened this issue Nov 7, 2017 · 0 comments
Assignees

Comments

@leokoppel
Copy link
Contributor

Platform

Platforms without pcl_visualization, perhaps without displays at all

Observed result

Build fails with libwave/wave_matching/include/wave/matching/pointcloud_display.hpp:23:46: fatal error: pcl/visualization/pcl_visualizer.h: No such file or directory

Desired result

wave_matching builds and is usable, except for visualization features

There are some decisions to be made. For example

  • Does wave_matching build in different configurations via preprocessor directives, or is there a separate module, e.g. wave_matching_visualization, which depends on pcl_visualization?
  • If the former, is the PointCloudDisplay class simply not built, or is it built as an empty interface with all its methods doing nothing (perhaps printing a warning at compile time)? That would allow client code to be compiled without changes for headless platforms, but is more complicated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants