Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated attribute version in docker-compose.yml #1595

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

h3ssan
Copy link

@h3ssan h3ssan commented Oct 25, 2024

Overview

In docker-compose.yml files we used to specify a version attribute, but nowadays is deprecated and no longer used. There's a warning message when using docker-compose.yml file with version attribute specified. Here's the warning message:

$ docker compose ps
WARN[0000] /dev/wazuh-docker/single-node/docker-compose.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion

Official Resources

The official docker documentation said the following about the version attribute.

The top-level version property is defined by the Compose Specification for backward compatibility. It is only informative and you'll receive a warning message that it is obsolete if used.

The Modified Files

  • single-node/docker-compose.yml
  • multi-node/docker-compose.yml

What did I modify

I removed the version attribute from both single-node/docker-compose.yml and multi-node/docker-compose.yml files.

@vcerenu vcerenu self-requested a review November 28, 2024 11:05
@vcerenu vcerenu assigned vcerenu and unassigned vcerenu Nov 28, 2024
@vcerenu
Copy link
Member

vcerenu commented Nov 28, 2024

Hello @h3ssan

I'll be reviewing the PR and I'll let you know if any changes are needed.

@vcerenu vcerenu mentioned this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants