PolySwarm Integration #698
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikman90
requested changes
Jun 26, 2020
There was a problem hiding this comment.
@JavierBotella the rules have a good structure.
However, we are reserving "1xxxxx" for custom user rules.
I suggest you use "91xxx", they are currently unused.
Thank you for this contribution!
|
thanks you @vikman90 updated. Let me know if any other issue there. thx! |
vikman90
approved these changes
Jul 6, 2020
There was a problem hiding this comment.
@JavierBotella I think that's great now.
I'm approving this PR. Now it is blocked by wazuh/wazuh#5175.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules file for this PR: PolySwarm Integration