Protect against maskedconstant return from gaia query of no RV #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went ahead and tested the case where the host star requested has no RV measurement in Gaia DR3. To test this, I tried initializing
backtracks.System
with target_name='Kepler-1900'. The previous try/except loop let this past without raising the Except, I think because the Gaia.query_object_async table for a star with no RV actually gives a numpy.ma.core.MaskedConstant object in the radial_velocity column.There was also a FutureWarning raised when trying to print this maskedconstant using format strings, so I added a if/else to protect against that, should numpy change this behavior in the future.
Creating a PR because I'm not sure if changing this try/except statement so dramatically leaves System.init unprotected to other exceptions Gilles was thinking of.