Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string for gridpoints and fix ISO interval #798

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JoshStern
Copy link

  • The gridpoint endpoint returns gridX and gridY as strings while other endpoints return them as integers. This updates the openapi definition to support that and will protect generated clients from parsing errors when they expect integers only. The long term fix will be to stick to integers but that is a breaking change which may take time to make safely.
  • The ISO8601 schema definition uses oneOf when a valid timestamp may satisfy multiple of the regexs provided. This updates to the anyOf keyword which will allow any match to pass instead of strictly one.

Related discussion: #768.

- The gridpoint endpoint returns gridX and gridY as strings while other
  endpoints return them as integers. This updates the openapi definition
  to support that (and will fix generated clients).
- The ISO8601 schema definition uses oneOf when a valid timestamp may
  satisfy multiple of the regexs provided. This updates to the anyOf
  keyword which better matches the desired behavior.
@JoshStern JoshStern marked this pull request as ready for review February 24, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant