Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hourly forecast design iteration #697

Merged
merged 5 commits into from
Jan 25, 2024
Merged

Hourly forecast design iteration #697

merged 5 commits into from
Jan 25, 2024

Conversation

eric-gade
Copy link
Collaborator

@eric-gade eric-gade commented Jan 23, 2024

What does this PR do? 🛠️

This PR implements the Hourly Forecast design iteration outlined in #679

What does the reviewer need to know? 🤔

In addition to the styling changes, I added the startTime for each hour as a timestamp so that it can be used properly in the <time> element. Previously, we were using a placeholder timestamp that was from 2011 😨

Sandbox testing

This branch is now deployed to my sandbox environment for live testing (as of this writing).

Screenshots (if appropriate): 📸

Mobile: Screen Shot 2024-01-23 at 4 19 50 PM
Desktop: Screen Shot 2024-01-23 at 4 19 41 PM

-- What
Due to limiations in how USWDS deals with li styling on a parent ol
with the `usa-list--unstyled` class present, we need to have a more
specific selector in order to add margins to the li elements. This
means we cannot use the utility classes on them directly.

This commit updates the custom stylesheet to make this exception.
Copy link
Collaborator

@greg-does-weather greg-does-weather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do it

Code Review Checklist

A checked item is either an assertion that I have tested this item or an indication that I have verified it does not apply to this pull request.

The Basics

  • Checks are passing
  • I read the code
  • I ran the code
  • (if applicable) Post deploy steps are run
  • (if applicable) I validated the change on the deployed version in

Documentation

  • changes to “how we do things” are documented in READMEs
  • all new functions and methods are commented using plain language
  • any new modules added documented in modules.md

Security

  • security false positives are documented
  • data from external sources is cleaned and clearly marked

Reliability

  • error handling exists for unusual or missing values
  • interactions with external systems are wrapped in try/except
  • functionality is tested with unit or integration tests
  • dependency updates in composer.json also got changed in composer-lock.json

Infrastructure

  • all changes are auditable and documented via a script
  • it is clear who can and should run the script
  • (if applicable) diagrams have been updated or added in PlantUML

Accessibility

  • New pages have been added to cypress-axe file so that they will be tested with our automated accessibility testing
  • Meets WCAG 2.0 AA or 2.1 AA for Section 508 compliance
    • Site is keyboard accessible. All interactions can be accessed with a keyboard
    • Site is free of keyboard traps. The keyboard focus is never trapped in a loop
    • All form inputs have explicit labels
    • Form instructions are associated with inputs
    • All relevant images use an img tag
    • All images have appropriate alt attributes
    • Multimedia is tagged. All multimedia has appropriate captioning and audio description
    • Text has sufficient color contrast. All text has a contrast ratio of 4.5:1 with the background
    • Site never loses focus. Focus is always visible when moving through the page with the keyboard
    • Tab order is logical
    • Tables are coded properly. Tables have proper headers and column attributes
    • Headings are nested properly. Heading elements are nested in a logical way
    • Language is set. The language for the page is set
    • CSS is not required to use the page. The page makes sense with or without CSS
    • Links are unique and contextual. All links can be understood taken alone, e.g., ‘Read more - about 508’
    • Page titles are descriptive

Device Matrix

  • firefox/gecko (renders correctly and user interactions work)
  • chrome/chromium/edge (renders correctly and user interactions work)
  • safari/webkit (renders correctly and user interactions work)
  • web page is readable and usable
    • at 480px (mobile)
    • at 640px (tablet)
    • at 1024px (desktop)

@eric-gade eric-gade added this pull request to the merge queue Jan 25, 2024
Merged via the queue into main with commit 91eb14d Jan 25, 2024
11 checks passed
@eric-gade eric-gade deleted the eg-679-iter-hourly branch January 25, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants