Skip to content

Commit

Permalink
fix(core): use modelId for modelCache
Browse files Browse the repository at this point in the history
  • Loading branch information
sunshinesmilelk authored and BroKun committed Apr 17, 2024
1 parent ed5d647 commit 3a07805
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 1 deletion.
33 changes: 33 additions & 0 deletions .changeset/sour-kiwis-tickle.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
---
"@difizen/libro-jupyter": patch
"@difizen/libro-core": patch
"@difizen/libro-docs": patch
"@difizen/libro-code-cell": patch
"@difizen/libro-code-editor": patch
"@difizen/libro-codemirror": patch
"@difizen/libro-cofine-editor": patch
"@difizen/libro-cofine-editor-contribution": patch
"@difizen/libro-cofine-editor-core": patch
"@difizen/libro-cofine-textmate": patch
"@difizen/libro-common": patch
"@difizen/libro-kernel": patch
"@difizen/libro-l10n": patch
"@difizen/libro-lab": patch
"@difizen/libro-language-client": patch
"@difizen/libro-lsp": patch
"@difizen/libro-markdown": patch
"@difizen/libro-markdown-cell": patch
"@difizen/libro-output": patch
"@difizen/libro-prompt-cell": patch
"@difizen/libro-raw-cell": patch
"@difizen/libro-rendermime": patch
"@difizen/libro-search": patch
"@difizen/libro-search-code-cell": patch
"@difizen/libro-shared-model": patch
"@difizen/libro-terminal": patch
"@difizen/libro-toc": patch
"@difizen/libro-virtualized": patch
"@difizen/libro-widget": patch
---

use modelId for modelCache
2 changes: 1 addition & 1 deletion packages/libro-core/src/libro-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ export class LibroService implements NotebookService, Disposable {
}
}
const model = this.libroModelFactory(options);
this.libroViewTracker.modelCache.set(model.id, model);
this.libroViewTracker.modelCache.set(options.modelId || model.id, model);
return model;
}
async getOrCreateView(options: NotebookOption): Promise<NotebookView> {
Expand Down

0 comments on commit 3a07805

Please sign in to comment.