This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
fix for issue #250 #251
Open
fix for issue #250 #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted the proper return value
As per 'https://goreleaser.com/deprecations#brewsgithub' adjusted the gorelease
bboreham
reviewed
Mar 1, 2021
| @@ -240,5 +240,5 @@ func (m *Machine) IsIgnite() (b bool) { | |||
| igniteChecked = true | |||
| } | |||
|
|
|||
| return | |||
| return b | |||
There was a problem hiding this comment.
The statement before means the same thing, since b is specified as a named return value.
In other words, you did not make any change to the meaning of the code.
| @@ -28,7 +28,7 @@ changelog: | |||
| - '^test:' | |||
| brews: | |||
| - | |||
| github: | |||
| tap: | |||
There was a problem hiding this comment.
Please explain more about why this change is needed.
Does it fix an issue?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted the proper return value