Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deperecate policyset crd #214

Merged
merged 2 commits into from
Dec 3, 2023
Merged

Conversation

waleedhammam
Copy link
Contributor

Closes #209

What changed?

  • Deprecate PolicySet CRD
  • Introduce new CRD version v2beta3 to have the new changes

Why was this change made?

  • The PolicySet CRD introduced more complexity to set up the policy agent.

How was this change implemented?

  • Remove all related policyset crd stuff

How did you validate the change?

  • run manually / unit / integration tests

Release notes

Documentation Changes

@waleedhammam waleedhammam added the enhancement New feature or request label Nov 26, 2023
@waleedhammam waleedhammam mentioned this pull request Nov 26, 2023
3 tasks
@waleedhammam waleedhammam force-pushed the 209-story-deprecate-policyset-crd branch 4 times, most recently from 359eb61 to 6659d62 Compare November 26, 2023 13:11
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a2a59c0) 78.34% compared to head (00ec46d) 78.34%.

Files Patch % Lines
controllers/policyconfig_controller.go 0.00% 1 Missing ⚠️
internal/policies/policy.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #214      +/-   ##
==========================================
- Coverage   78.34%   78.34%   -0.01%     
==========================================
  Files          22       20       -2     
  Lines        1390     1279     -111     
==========================================
- Hits         1089     1002      -87     
+ Misses        229      211      -18     
+ Partials       72       66       -6     
Flag Coverage Δ
unit 78.34% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waleedhammam waleedhammam force-pushed the 209-story-deprecate-policyset-crd branch 6 times, most recently from 6f9b5b8 to 847de1f Compare November 26, 2023 13:50
@waleedhammam waleedhammam force-pushed the 209-story-deprecate-policyset-crd branch from 847de1f to 627e804 Compare November 26, 2023 14:33
@waleedhammam waleedhammam force-pushed the 209-story-deprecate-policyset-crd branch from 5d3f267 to 00ec46d Compare November 28, 2023 15:27
Copy link
Member

@Samra10 Samra10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and Audit/Enforce fields in the UI not affected

@waleedhammam waleedhammam merged commit 3878765 into dev Dec 3, 2023
5 of 6 checks passed
@waleedhammam waleedhammam deleted the 209-story-deprecate-policyset-crd branch December 3, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Story] Deprecate PolicySet CRD
2 participants