Fix kubeconfig script #3881
Closed
Fix kubeconfig script #3881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
This updates the static-kubeconfig.sh script to generate valid YAML.
bigkevmcd
force-pushed
the
fix-kubeconfig-script
branch
from
ba291fd to
0622dfb
Compare
bigkevmcd
force-pushed
the
fix-kubeconfig-script
branch
from
0622dfb to
0b78d13
Compare
|
Weren't any reviewers chosen so I added a few to get this moving forward. |
|
reviewed e2e journey for that documentation with a few suggestions in form of new PR #3988 |
|
What's the status of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
What changed?
Fixes the indentation in the
static-kubeconfig.shto generate valid YAML.Why was this change made?
The script was generating invalid YAML
How was this change implemented?
How did you validate the change?
Running the recommend command from the docs with the old version creates an invalid YAML that fails with
kubectl --kubeconfigwith invalid YAML on line 5, running it with a file generated using this command it works.Release notes
No
Documentation Changes