This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
Improve path helper library #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make commands more copy-pastable - Removes code-gen section - Mention footloose / vagrant
Refactor Readme
ci: Add release on tag with goreleaser
Return git tag instead of branch+hash if commit is tagged.
…eworks#18) * beginnings of "wksctl init" * all translations now in * support running with OR without stored manifests for flux and wks-controller * Restore flux test into os_test; deal with mismatch in footloose cluster.New() signature * clean up arguments to "init"
* Update installation instructions to use release binary
* remove reference to personal github account * uses weaveworks for example repos
add some basic community information, link to resources
fix link to fluxctl docs
This change is intended to clean up the code, but leave behavior unmodified.
…factor-specs Refactor: extract `specs` from `main` to a separate package.
This is because we don't seem to use the context in any meaningful way here.
[WKP-142] Add rhel support
- add selinux fix right after installing docker package on centos - prevent setenforce failure - set selinux permissive only when it needs to be - fix selinux permissive check
Fix SELinux permissive mode detection logic
* only push image if quay.io credentials are present * fix command to be multi-line string * flip backward test * Add comment so circle will see the previous change * only run gcp integration tests if secret key is available * fix typo in config file * Update rhel test to check for secret_key Co-authored-by: Jerry Jackson <[email protected]> Co-authored-by: Mark Emeis <[email protected]>
Update docs bits
Change liche args
The original machines.yaml didn't seem to be valid anymore. Also updated the wks-controller log command and removed wksctl apply args where they matched defaults.
* Fix behavior of path.WKSHome so that it will work correctly for wkp * tests for WKSHome Co-authored-by: Jerry Jackson <[email protected]>
stealthybox
force-pushed
the
path-lib
branch
2 times, most recently
from
00f0fb0 to
1fb5dda
Compare
|
Please could you modifiy the description to focus less on what you did (we can see that in the diffs) and more on why you did it. |
|
Please could you rebase this PR as, following some accident, master got force-pushed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: