Skip to content

Commit

Permalink
Remove 1.25.X and 1.26.X versions with upgrade bug.
Browse files Browse the repository at this point in the history
There was a bug which deleted the collection
after the upgrade in older 1.25 and 1.26 versions:
weaviate/weaviate#5971
Therefore, we are skipping those versions without
the fix to avoid the upgrade journey to fail.
  • Loading branch information
jfrancoa committed Jan 21, 2025
1 parent 4c77651 commit 9c4c4db
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/matrix.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
weaviate-version-information:
runs-on: ubuntu-latest
env:
weaviate_version: "${{inputs.weaviate_version || '1.27.2'}}"
weaviate_version: "${{inputs.weaviate_version || '1.28.3'}}"
outputs:
weaviate_version: ${{ steps.set-output.outputs.weaviate_version }}
steps:
Expand All @@ -43,7 +43,7 @@ jobs:
uses: ./.github/workflows/tests.yaml
with:
lsm_access_strategy: ${{matrix.lsm_access_strategy}}
weaviate_version: ${{ github.event_name == 'schedule' && 'nightly' || inputs.weaviate_version || '1.27.2' }}
weaviate_version: ${{ github.event_name == 'schedule' && 'nightly' || inputs.weaviate_version || '1.28.3' }}
secrets:
AWS_ACCESS_KEY: ${{secrets.AWS_ACCESS_KEY}}
AWS_SECRET_ACCESS_KEY: ${{secrets.AWS_SECRET_ACCESS_KEY}}
Expand All @@ -64,7 +64,7 @@ jobs:
# This data has been defined as a Workflow in the slack channel chaos-pipeline
payload: |
{
"message": "Chaos pipeline failed for Weaviate version: latest.\nLink: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}",
"message": "Chaos pipeline failed for Weaviate version: nightly.\nLink: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}",
"slack_channel": "${{ env.SLACK_CHANNEL }}"
}
env:
Expand Down
8 changes: 8 additions & 0 deletions apps/upgrade-journey/versions.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"log"
"net/http"
"regexp"
"slices"
"sort"
"time"

Expand All @@ -18,6 +19,9 @@ import (
"github.com/weaviate/weaviate-go-client/v4/weaviate"
)

// skip versions that are not compatible with the upgrade journey due to bugs or breaking changes
var skipVersions = []string{"1.25.0", "1.25.1", "1.25.2", "1.25.3", "1.25.4", "1.25.5", "1.25.6", "1.25.7", "1.25.8", "1.25.9", "1.25.10", "1.25.11", "1.25.12", "1.25.13", "1.25.14", "1.25.15", "1.25.16", "1.25.17", "1.25.18", "1.25.19", "1.26.0", "1.26.1", "1.26.2", "1.26.3", "1.26.4", "1.26.5"}

func buildVersionList(ctx context.Context, min, target string) ([]string, error) {
ghReleases, err := retrieveVersionListFromGH()
if err != nil {
Expand Down Expand Up @@ -129,6 +133,10 @@ func sortSemverAndTrimToMinimum(versions semverList, min, max string) semverList

i := 0
for _, version := range versions {
// if the version is in the skipVersions list, skip it
if slices.Contains(skipVersions, version.version.String()) {
continue
}
if !version.largerOrEqual(minV) {
continue
}
Expand Down

0 comments on commit 9c4c4db

Please sign in to comment.