Skip to content

Commit

Permalink
Fix macOS appstore review issues
Browse files Browse the repository at this point in the history
WE2-494

Signed-off-by: Raul Metsma <[email protected]>
  • Loading branch information
metsma authored and mrts committed Jul 16, 2021
1 parent 412fafc commit 4ed620f
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ elseif($ENV{CI_PIPELINE_IID})
else()
set(BUILD_NUMBER 0)
endif()
project(web-eid VERSION 1.0.0.${BUILD_NUMBER})
project(web-eid VERSION 1.0.1.${BUILD_NUMBER})

set(MACOSX_BUNDLE_SHORT_VERSION_STRING "${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH}")
set(MACOSX_BUNDLE_BUNDLE_VERSION ${PROJECT_VERSION_TWEAK})
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ https://github.com/mrts/docker-qt-cmake-gtest-valgrind-ubuntu/blob/master/Docker

- Install _CMake_, _Google Test_, _OpenSSL_ and _Qt_ with _Homebrew_:

brew install cmake web-eid/gtest/gtest openssl qt@5
brew install cmake web-eid/gtest/gtest openssl qt@5 node

- Create symlink to _OpenSSL_ location and setup environment variables required
by _CMake_:
Expand Down
Binary file modified install/appicon.icns
Binary file not shown.
4 changes: 3 additions & 1 deletion src/mac/Info-extension.plist.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@
<key>CFBundleInfoDictionaryVersion</key>
<string>6.0</string>
<key>CFBundleName</key>
<string>${MACOSX_BUNDLE_EXECUTABLE_NAME}</string>
<string>Web eID Safari Extension</string>
<key>CFBundleDisplayName</key>
<string>Web eID Safari Extension</string>
<key>CFBundlePackageType</key>
<string>XPC!</string>
<key>CFBundleShortVersionString</key>
Expand Down
2 changes: 1 addition & 1 deletion src/mac/js
2 changes: 1 addition & 1 deletion src/mac/shared.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

static NSString* WebEidApp = @"eu.web-eid.web-eid-safari";
static NSString* WebEidExtension = @"eu.web-eid.web-eid-safari.web-eid-safari-extension";
static NSString* WebEidShared = @"eu.web-eid.web-eid-safari.shared";
static NSString* WebEidShared = @"ET847QJV9F.eu.web-eid.web-eid-safari.shared";
static NSString* WebEidStarting = @"eu.web-eid.web-eid-safari.starting";

#if __MAC_OS_X_VERSION_MIN_REQUIRED < 110000
Expand Down
2 changes: 1 addition & 1 deletion src/mac/web-eid-safari-extension.entitlements
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<true/>
<key>com.apple.security.application-groups</key>
<array>
<string>eu.web-eid.web-eid-safari.shared</string>
<string>ET847QJV9F.eu.web-eid.web-eid-safari.shared</string>
</array>
</dict>
</plist>
2 changes: 1 addition & 1 deletion src/mac/web-eid-safari.entitlements
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<true/>
<key>com.apple.security.application-groups</key>
<array>
<string>eu.web-eid.web-eid-safari.shared</string>
<string>ET847QJV9F.eu.web-eid.web-eid-safari.shared</string>
</array>
<key>com.apple.security.smartcard</key>
<true/>
Expand Down

0 comments on commit 4ed620f

Please sign in to comment.