Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Action to upload complete source tarball #279

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add GitHub Action to upload complete source tarball #279

wants to merge 1 commit into from

Conversation

klemensn
Copy link
Contributor

Signed-off-by: Klemens Nanni [email protected]

@klemensn klemensn mentioned this pull request Jul 13, 2023
Open
@klemensn
Copy link
Contributor Author

I've created a bunch of tags and releases in my fork; after cloning all your repositories so that the hook would finish recursively cloning all submodules (from my account), https://github.com/klemensn/web-eid-app/actions/runs/5561964558/jobs/10159971653#step:4:10 shows that the actual upload action usage needs fixing.

@klemensn klemensn marked this pull request as ready for review July 16, 2023 19:43
@klemensn
Copy link
Contributor Author

If used on the current release, this would've created web-eid-app-full-2.3.1.tar.gz containing a web-eid-app-full-2.3.1/ directory with all source files including submodules.

-full is needed, otherwise tarball and directory are named like the auto-generated one.

I've tested this with releases on my fork.

@mrts
Copy link
Member

mrts commented Jul 17, 2023

Excellent, thank you! We will merge this during the v2.5 development cycle which will begin in end of July/beginning of August.

@klemensn
Copy link
Contributor Author

klemensn commented Aug 6, 2023

Excellent, thank you! We will merge this during the v2.5 development cycle which will begin in end of July/beginning of August.

That means the next v2.4 release won't get a tarball generated by this, right?
If so, could you upload one manually to simplify the next package update for maintainers?

@mrts
Copy link
Member

mrts commented Sep 22, 2023

That means the next v2.4 release won't get a tarball generated by this, right?
If so, could you upload one manually to simplify the next package update for maintainers?

Yes, that's correct, the v2.4 release doesn't have an automatically generated tarball. Sure, we'll ensure to upload one manually when time allows.

mrts
mrts requested changes Sep 29, 2023
View reviewed changes
.github/workflows/release-tarball.yml Outdated Show resolved Hide resolved
.github/workflows/release-tarball.yml Outdated Show resolved Hide resolved
@klemensn
Upload complete source tarball as release asset
d0b4a64 
Contrary to auto-generated release tarballs, this one includes all
submodules such that operating system infrastructure gets a complete
source tree wihtout having to fetch submodules themself.

Add "-full" between name and version to distinguish the two tarballs.

The token needs read/write permissions to clone the repository and
upload assets to existing releases, respectively.

Fixes web-eid#274

Signed-off-by: Klemens Nanni <[email protected]>
@klemensn
Copy link
Contributor Author

Friendly ping, I also rebased onto latest master as suggested by GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrts mrts mrts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klemensn @mrts