Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove router field in runtimeContext #6497

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

zllkjc
Copy link
Member

@zllkjc zllkjc commented Nov 5, 2024

Summary

this field is only for inhouse framework, now we decoupling the implements

Related Links

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Nov 5, 2024

⚠️ No Changeset found

Latest commit: 6f085b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for modernjs-byted ready!

Name Link
🔨 Latest commit 6f085b0
🔍 Latest deploy log https://app.netlify.com/sites/modernjs-byted/deploys/672b2256755cd40008aeab61
😎 Deploy Preview https://deploy-preview-6497--modernjs-byted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 80 (🔴 down 2 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@zllkjc zllkjc force-pushed the chore/remove-router-context branch from 7cc2724 to 42b82bb Compare November 6, 2024 07:58
@zllkjc zllkjc changed the title WIP chore: remove router field in runtimeContext chore: remove router field in runtimeContext Nov 6, 2024
@caohuilin caohuilin merged commit fe9264a into main Nov 6, 2024
12 checks passed
@caohuilin caohuilin deleted the chore/remove-router-context branch November 6, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants