Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(infra): implement click to reference by tsconfig.reference #1790

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Jan 28, 2025

Summary

this is a trick for implementing "click to reference" of ts-language-server

tsc will build the .d.ts.map in memory

so we need to set rootDir: "src" "outDir: "dist"" composite: true and tsconfig.reference just like Rsbuild repo

img_v3_02iv_0cb9e632-dd84-465c-bf86-39fe0f25b46g

BTW, fix some type error when debugging references

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit e3a9f5a
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/679891eec147410008d0bd91
😎 Deploy Preview https://deploy-preview-1790--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter SoonIter marked this pull request as ready for review January 28, 2025 08:24
@Timeless0911
Copy link
Contributor

Check whether the DTS output of each package is as expected.

@SoonIter SoonIter merged commit b9e865b into main Jan 28, 2025
11 checks passed
@SoonIter SoonIter deleted the tsconfig-reference branch January 28, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants