Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update Node.js install in CONTRIBUTING.md #1821

Merged
merged 1 commit into from
Feb 7, 2025
Merged

chore: update Node.js install in CONTRIBUTING.md #1821

merged 1 commit into from
Feb 7, 2025

Conversation

Timeless0911
Copy link
Contributor

Summary

update Node.js install in CONTRIBUTING.md

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Timeless0911 Timeless0911 requested a review from SoonIter February 7, 2025 03:37
@Timeless0911 Timeless0911 enabled auto-merge (squash) February 7, 2025 03:37
@netlify Netlify
Copy link

netlify bot commented Feb 7, 2025 •
edited
Loading

✅ Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 4e4c437
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67a580110d4c7a0008de2159
😎 Deploy Preview https://deploy-preview-1821--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 93 (🟢 up 28 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

chenjiahan
chenjiahan reviewed Feb 7, 2025
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part should be updated too: https://github.com/web-infra-dev/rspress/blob/main/CONTRIBUTING.md#benchmarking

@Timeless0911 Timeless0911 merged commit dd84260 into main Feb 7, 2025
11 checks passed
@Timeless0911 Timeless0911 deleted the chore/readme branch February 7, 2025 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan left review comments

@SoonIter SoonIter SoonIter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Timeless0911 @chenjiahan @SoonIter