build: move some packages to be built by Rslib #1824
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding an empty virtual module in
packages/core/src/node/runtimeModule/routeData.ts
as a placeholder. The reason is:The output of Rslib be like:
Which can not be static determined by Rspack when bundling even
process.env.__SSR__
is statically replaced to a boolean value. So Rspack will try to resolve bothvirtual-routes
andvirtual-routes-ssr
for SSR and non-SSR. Adding an empty virtual module here as a placeholder.Related Issue
Checklist