FSA: Fail to create a writable if the file does not exist #39919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 10, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4520224
branch
from
b7af3d7
to
a46a1e4
Compare
DO NOT MERGE (yet) whatwg/fs#125 Currently, the createWritable() algorithm specifies that we must throw a NotFoundError if the file corresponding to the FileSystemHandle does not exist. See https://fs.spec.whatwg.org/#dom-filesystemfilehandle-createwritable Unfortunately, this does not match the behavior that has been implemented in Chrome for a very long time; specifically that - createWritable({ keepExistingData: true }) fails if the file does not exist, since there is no existing data to copy to the swap file - createWritable({ keepExistingData: false }) succeeds if the file does not exist, since there is no existing data to copy. It still fails if the parent directory does not exist, however Bug: 1405851 Change-Id: I788c5b177c188862d4b08b5dd876404522fa32d5
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4520224
branch
from
a46a1e4
to
7695800
Compare
|
Close this PR because the Chromium CL has been abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE (yet) whatwg/fs#125
Currently, the createWritable() algorithm specifies that we must throw
a NotFoundError if the file corresponding to the FileSystemHandle does
not exist. See
https://fs.spec.whatwg.org/#dom-filesystemfilehandle-createwritable
Unfortunately, this does not match the behavior that has been
implemented in Chrome for a very long time; specifically that
not exist, since there is no existing data to copy to the swap file
does not exist, since there is no existing data to copy. It still
fails if the parent directory does not exist, however
Bug: 1405851
Change-Id: I788c5b177c188862d4b08b5dd876404522fa32d5
Reviewed-on: https://chromium-review.googlesource.com/4520224
WPT-Export-Revision: f019307801c3cff54e0919eb1839a39c5002a899