Reland Soft Navigation Patches #44007
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 15, 2024
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5199092
branch
2 times, most recently
from
6e3b827 to
b3e68e8
Compare
This is a reland of commit bc3a536a4fc930ff5161c7795758e72893b6afca, which was reverted in ba0a09e0fca6c7e8e98ad168d52684e4b3f34a08. Original change's description: > Reland "[soft-navigations] move startTime to processing end" > > This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9 > > It better takes into account event bubbling, and the fact we see > multiple tasks in a single EventScope in those cases. It also tests this case specifically. > > Bug: 1505059 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713 > Commit-Queue: Yoav Weiss <[email protected]> > Reviewed-by: Ian Clelland <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1231299} Original original change's description: > [soft-navigations] move startTime to processing end > > This CL aligns the implementation with [1], and sets the soft navigation > start time to be the processingEnd of the relevant earlier event. > > It also cleans up a few bits of code that became useless, as well as > issues around PerInteractionData copying that were buggy yet hidden > before the timing of setting the different attributes was changed. > > > [1] WICG/soft-navigations#14 > > Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5 > Bug: 1505059 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108 > Reviewed-by: Ian Clelland <[email protected]> > Commit-Queue: Yoav Weiss <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1230490} Bug: 1505059 Change-Id: Ib70187d5b6335d57705cc15b62a33e142884dd99
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5199092
branch
from
b3e68e8 to
00f2cfe
Compare
|
Close this PR because the Chromium CL has been abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of commit bc3a536a4fc930ff5161c7795758e72893b6afca, which was
reverted in ba0a09e0fca6c7e8e98ad168d52684e4b3f34a08.
Original change's description:
Original original change's description:
Bug: 1505059
Change-Id: Ib70187d5b6335d57705cc15b62a33e142884dd99
Reviewed-on: https://chromium-review.googlesource.com/5199092
WPT-Export-Revision: 8270f9d11be7b27a2bda50e380623d780401e4ee