URL: trailing spaces always get removed from opaque paths #51129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
annevk
added a commit
to annevk/WebKit
that referenced
this pull request
Mar 5, 2025
https://bugs.webkit.org/show_bug.cgi?id=289160 Reviewed by NOBODY (OOPS!). Instead of attempting to account for opaque paths sometimes ending in spaces in the API implementation and failing because that did not account for serialization, this new approach never lets them end with spaces, period. This is standardized here: whatwg/url#844 Test changes are upstreamed here: web-platform-tests/wpt#51129 * LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/resources/setters_tests.json: * LayoutTests/imported/w3c/web-platform-tests/url/resources/urltestdata.json: * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-delete.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-delete.any.js: (test): * LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-delete.any.worker-expected.txt: * Source/WTF/wtf/URL.cpp: (WTF::URL::removeFragmentIdentifier): (WTF::URL::removeQueryAndFragmentIdentifier): (WTF::URL::setQuery): (WTF::URL::maybeTrimTrailingSpacesFromOpaquePath): Deleted. * Source/WTF/wtf/URL.h: * Source/WTF/wtf/URLParser.cpp: (WTF::URLParser::parse):
annevk
added a commit
to annevk/WebKit
that referenced
this pull request
Mar 5, 2025
https://bugs.webkit.org/show_bug.cgi?id=289160 Reviewed by NOBODY (OOPS!). Instead of attempting to account for opaque paths sometimes ending in spaces in the API implementation and failing because that did not account for serialization, this new approach never lets them end with spaces, period. This is standardized here: whatwg/url#844 Test changes are upstreamed here: web-platform-tests/wpt#51129 * LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/resources/setters_tests.json: * LayoutTests/imported/w3c/web-platform-tests/url/resources/urltestdata.json: * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-delete.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-delete.any.js: (test): * LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-delete.any.worker-expected.txt: * Source/WTF/wtf/URL.cpp: (WTF::URL::removeFragmentIdentifier): (WTF::URL::removeQueryAndFragmentIdentifier): (WTF::URL::setQuery): (WTF::URL::maybeTrimTrailingSpacesFromOpaquePath): Deleted. * Source/WTF/wtf/URL.h: * Source/WTF/wtf/URLParser.cpp: (WTF::URLParser::parse):
karwa
reviewed
Mar 6, 2025
Comment on lines
+3782
to
+3825
| "input": "non-special:opaque ", | ||
| "base": null, | ||
| "href": "non-special:opaque", | ||
| "origin": "null", | ||
| "protocol": "non-special:", | ||
| "username": "", | ||
| "password": "", | ||
| "host": "", | ||
| "hostname": "", | ||
| "port": "", | ||
| "pathname": "opaque", | ||
| "search": "", | ||
| "hash": "" | ||
| }, | ||
| { | ||
| "input": "non-special:opaque ?hi", | ||
| "base": null, | ||
| "href": "non-special:opaque?hi", | ||
| "origin": "null", | ||
| "protocol": "non-special:", | ||
| "username": "", | ||
| "password": "", | ||
| "host": "", | ||
| "hostname": "", | ||
| "port": "", | ||
| "pathname": "opaque", | ||
| "search": "?hi", | ||
| "hash": "" | ||
| }, | ||
| { | ||
| "input": "non-special:opaque #hi", | ||
| "base": null, | ||
| "href": "non-special:opaque#hi", | ||
| "origin": "null", | ||
| "protocol": "non-special:", | ||
| "username": "", | ||
| "password": "", | ||
| "host": "", | ||
| "hostname": "", | ||
| "port": "", | ||
| "pathname": "opaque", | ||
| "search": "", | ||
| "hash": "#hi" | ||
| }, |
There was a problem hiding this comment.
It might be useful to add a copy of these with a trailing %20 (which should not be stripped)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatwg/url#844.