-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make status bar work great in all kind of modes #363
Conversation
RichardLindhout
commented
Dec 21, 2023
•
edited
Loading
edited
![Schermafbeelding 2023-12-21 om 19 50 08](https://private-user-images.githubusercontent.com/6492229/292293614-1ec02a5c-4551-476e-b534-f681c75d1627.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzk4NDUsIm5iZiI6MTczOTMzOTU0NSwicGF0aCI6Ii82NDkyMjI5LzI5MjI5MzYxNC0xZWMwMmE1Yy00NTUxLTQ3NmUtYjUzNC1mNjgxYzc1ZDE2MjcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTJUMDU1MjI1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NmJiZDQ5OTU3Mzc1NDYzNjQwNDYyM2Y4Mzk4ZTQzNTc5ZGE0NDJlN2I3NDRlODdhYzE2YjYzZDliYTI2NmFhMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.jEiQi987jKifCsVyA9_jn1EYAMQkQ5C0mUQeLmORtDA)
![Schermafbeelding 2023-12-21 om 19 50 30](https://private-user-images.githubusercontent.com/6492229/292293616-11d7ac26-e619-4f13-a8fd-86c77c7a1f9f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzk4NDUsIm5iZiI6MTczOTMzOTU0NSwicGF0aCI6Ii82NDkyMjI5LzI5MjI5MzYxNi0xMWQ3YWMyNi1lNjE5LTRmMTMtYThmZC04NmM3N2M3YTFmOWYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTJUMDU1MjI1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTYxZWY0NWUzMWJkYTM1MWU5OTZjNTBjYWIwZjA0OWE2NmExZDhjMGM5ZjIwYTIyOTcyOTE1ZDM4ZTc5NmExNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.S0StrAqRibJo0Gg13cdEbwv9NzkvpWuSd5EClmWRywc)
![Schermafbeelding 2023-12-21 om 19 52 37](https://private-user-images.githubusercontent.com/6492229/292293622-8697242d-8417-406f-a672-73abcb7eb7b8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzk4NDUsIm5iZiI6MTczOTMzOTU0NSwicGF0aCI6Ii82NDkyMjI5LzI5MjI5MzYyMi04Njk3MjQyZC04NDE3LTQwNmYtYTY3Mi03M2FiY2I3ZWI3YjgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTJUMDU1MjI1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NjA0Yjg4ZjE4NjBlYjJjODNmMmU2YjkwYTRmNjk2YmM0NWNkY2RmZTg5YjQzYWE3YWFlM2FmNTkyN2Q3NjI3MyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.oncU-ejEUif3SmDVyQmOAjZZppTYHvJRAe1UjxemoWU)
![Schermafbeelding 2023-12-21 om 19 52 44](https://private-user-images.githubusercontent.com/6492229/292293626-ec4fa2df-2260-4464-bf9d-060bc638b0bd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzk4NDUsIm5iZiI6MTczOTMzOTU0NSwicGF0aCI6Ii82NDkyMjI5LzI5MjI5MzYyNi1lYzRmYTJkZi0yMjYwLTQ0NjQtYmY5ZC0wNjBiYzYzOGIwYmQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTJUMDU1MjI1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NzI2MzM1NTRjZjQ3MGFkNjRkNDI5ZTJlMWRjMmU2ODYxOWYzNTcxZmIxZWZiZjZkMTA1NTg4NDRiMDJlZWU0YyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.El4h-YfF6nSsD-9RY_iOZfRNAPQVan5cAie3ujAz33s)
![Schermafbeelding 2023-12-21 om 19 52 59](https://private-user-images.githubusercontent.com/6492229/292293629-5886abde-c152-408c-adde-c7dbf47c3cd6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzk4NDUsIm5iZiI6MTczOTMzOTU0NSwicGF0aCI6Ii82NDkyMjI5LzI5MjI5MzYyOS01ODg2YWJkZS1jMTUyLTQwOGMtYWRkZS1jN2RiZjQ3YzNjZDYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTJUMDU1MjI1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZjNmZjg4YmFmM2M3Njc2NDUzNGJlNjIwOThkZWEwN2JiYTU1MWM1NzkxYjAzODIxZDhhZmJiOGVhNDE2MjIyOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.QVkOwiYJHwzT6YgcfNMQ3S_N6lovg3ymp32Ex5phdj8)
Let's get rid of some of the commented out code if it's OBE. |
@RichardLindhout This still seems to be an issue on the latest version as @SoyDiego has pointed out. |
This is a bug in the react native statusbar component when inside a modal unfortunaly. I was hoping it was only in the development build of expo and not in production. But on the snack someone provided it does seem to work. Let me try again what's the difference with our stuff |
It does seem like the modalBackground has effect on statusbar somehow.. |
It does work in this snack but not on my android emulator... https://snack.expo.dev/@richardlindhout/status-bar-tester |
It does seem to work if you put
In your app.tsx like in example. Only the statusbar does not update itself on android it seems to e.g. light-content if background is dark. |