Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve pins vs uploads experience on account page #2117 #1947 #2147

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 28 additions & 21 deletions packages/website/components/account/filesManager/filesManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { useRouter } from 'next/router';
import CheckIcon from 'assets/icons/check';
import { useUploads } from 'components/contexts/uploadsContext';
import { usePinRequests } from 'components/contexts/pinRequestsContext';
import { useUser } from 'components/contexts/userContext';
import UploadsTable from './uploadsTable';
import PinRequestsTable from './pinRequestsTable';

Expand All @@ -26,6 +27,7 @@ import PinRequestsTable from './pinRequestsTable';
* @returns
*/
const FilesManager = ({ className, content, onFileUpload }) => {
const { info: userInfo } = useUser();
const { count: uploadsCount } = useUploads();
const { count: pinRequestsCount } = usePinRequests();
const { query, replace } = useRouter();
Expand All @@ -36,23 +38,27 @@ const FilesManager = ({ className, content, onFileUpload }) => {

// Set current tab based on url param on load
useEffect(() => {
if (query.hasOwnProperty('table') && currentTab !== query?.table) {
if (typeof query.table === 'string') {
if (query.table === 'pinned' && pinRequestsCount === 0) {
delete query.table;
replace(
{
query,
},
undefined,
{ shallow: true }
);
return;
if (query.hasOwnProperty('table') && currentTab !== query?.table && typeof query.table === 'string') {
if (query.table === 'pinned') {
if (userInfo) {
if (!userInfo.tags?.HasPsaAccess) {
delete query.table;
replace(
{
query,
},
undefined,
{ shallow: true }
);
} else {
setCurrentTab(query.table);
}
}
} else {
setCurrentTab(query.table);
}
}
}, [query, currentTab, pinRequestsCount, replace]);
}, [query, currentTab, userInfo, replace]);

const changeCurrentTab = useCallback(
/** @type {string} */ tab => {
Expand Down Expand Up @@ -90,12 +96,11 @@ const FilesManager = ({ className, content, onFileUpload }) => {

return (
<div className={clsx('section files-manager-container', className, isUpdating && 'disabled')}>
{pinRequestsCount > 0 && (
{userInfo?.tags?.HasPsaAccess && (
<div className="upload-pinned-selector">
{content?.tabs.map(tab => (
<div key={tab.file_type} className="filetype-tab">
<button
disabled={tab.file_type === 'pinned' && pinRequestsCount === 0}
className={clsx('tab-button', currentTab === tab.file_type ? 'selected' : '')}
onClick={() => changeCurrentTab(tab.file_type)}
>
Expand All @@ -113,12 +118,14 @@ const FilesManager = ({ className, content, onFileUpload }) => {
onUpdatingChange={setIsUpdating}
showCheckOverlay={showCheckOverlayHandler}
/>
<PinRequestsTable
content={content}
hidden={currentTab !== 'pinned'}
onUpdatingChange={setIsUpdating}
showCheckOverlay={showCheckOverlayHandler}
/>
{userInfo?.tags?.HasPsaAccess && (
<PinRequestsTable
content={content}
hidden={currentTab !== 'pinned'}
onUpdatingChange={setIsUpdating}
showCheckOverlay={showCheckOverlayHandler}
/>
)}
<div className={clsx('files-manager-overlay', showCheckOverlay ? 'show' : '')}>
<div className="files-manager-overlay-check">
<CheckIcon />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@
min-height: 23.4375rem;
}

.files-manager-upload-cta {
.files-manager-table-message {
@include fontWeight_Regular;
@include fontSize_Medium;
padding-left: 3.125rem;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import GradientBackground from '../../gradientbackground/gradientbackground.js';
* @param {PinRequestsTableProps} props
*/
const PinRequestsTable = ({ content, hidden, onUpdatingChange, showCheckOverlay }) => {
const { pinRequests, pages, fetchDate, getPinRequests, isFetching, deletePinRequest } = usePinRequests();
const { pinRequests, pages, fetchDate, getPinRequests, isFetching, deletePinRequest, count } = usePinRequests();
const {
storageData: { refetch },
} = useUser();
Expand Down Expand Up @@ -159,42 +159,46 @@ const PinRequestsTable = ({ content, hidden, onUpdatingChange, showCheckOverlay
}}
/>
</div>
<PinRequestRowItem
onSelect={onSelectAllToggle}
date={fileRowLabels.date.label}
name={fileRowLabels.name.label}
cid={fileRowLabels.cid.label}
requestid={fileRowLabels.requestid.label}
status={fileRowLabels.status.label}
linkPrefix={linkPrefix}
isHeader
isSelected={
!!selectedPinRequests.length &&
pinRequests.every(file => selectedPinRequests.find(fileSelected => file === fileSelected)) &&
!!fetchDate
}
/>
<div className="files-manager-table-content">
{isFetching || !fetchDate ? (
<Loading className={'files-loading-spinner'} />
) : !count ? (
<span className="files-manager-table-message">{content?.table.pins_message}</span>
) : (
pinRequests.map(item => (
<>
<PinRequestRowItem
key={item.requestid}
onSelect={() => onPinRequestSelect(item)}
date={item.created}
name={item.pin.name || 'No Name'}
cid={item.pin.cid}
requestid={item.requestid}
status={item.status}
onSelect={onSelectAllToggle}
date={fileRowLabels.date.label}
name={fileRowLabels.name.label}
cid={fileRowLabels.cid.label}
requestid={fileRowLabels.requestid.label}
status={fileRowLabels.status.label}
linkPrefix={linkPrefix}
isSelected={!!selectedPinRequests.find(fileSelected => fileSelected === item)}
onDelete={() => onDeleteSingle(item.requestid)}
isHeader
isSelected={
!!selectedPinRequests.length &&
pinRequests.every(file => selectedPinRequests.find(fileSelected => file === fileSelected)) &&
!!fetchDate
}
/>
))
{pinRequests.map(item => (
<PinRequestRowItem
key={item.requestid}
onSelect={() => onPinRequestSelect(item)}
date={item.created}
name={item.pin.name || 'No Name'}
cid={item.pin.cid}
requestid={item.requestid}
status={item.status}
linkPrefix={linkPrefix}
isSelected={!!selectedPinRequests.find(fileSelected => fileSelected === item)}
onDelete={() => onDeleteSingle(item.requestid)}
/>
))}
</>
)}
</div>
{!!pinRequests.length && (
{!!count && (
<div className="files-manager-footer">
<button
className={clsx('delete', !selectedPinRequests.length && 'disabled')}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ const UploadsTable = ({ content, hidden, onFileUpload, onUpdatingChange, showChe
onSelectAll={onSelectAllToggle}
onDelete={onDeleteSingle}
emptyState={
<span className="files-manager-upload-cta">
<span className="files-manager-table-message">
{content?.table.message}
{'\u00A0'}
<Button
Expand Down
3 changes: 2 additions & 1 deletion packages/website/components/contexts/userContext.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@ import React from 'react';
import { useQuery } from 'react-query';

import { getInfo, getStorage } from 'lib/api.js';
import { useAuthorization } from './authorizationContext.js';
import AccountBlockedModal from 'components/account/accountBlockedModal/accountBlockedModal.js';
import { useAuthorization } from './authorizationContext.js';

/**
* @typedef Tags
* @property {boolean} [HasAccountRestriction]
* @property {boolean} [HasPsaAccess]
*/

/**
Expand Down
1 change: 1 addition & 0 deletions packages/website/content/pages/app/account.json
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@
"action": "Upload File",
"accountRestrictedText": "You are unable to upload files when your account is blocked. Please contact [email protected]"
},
"pins_message": "You don't have any files pinned yet.",
"file_row_labels": {
"date": {
"label": "Date"
Expand Down