Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GH workflow logic to upload Playwright reports to web3.storage #2161

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: GH workflow logic to upload Playwright reports to web3.storage #2161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/website.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ on:
description: Whether to add add_playwright_report_to_web3_storage to web3.storage (publicly)
required: true
type: boolean
# Note that this default does NOT set the value for when triggered by a push/pull request
default: true
force_release:
description: Whether to run the release job no matter what
Expand Down Expand Up @@ -88,7 +89,7 @@ jobs:

- run: npx playwright install --with-deps ${{ matrix.browser }}
working-directory: packages/website

# run e2e tests
- id: website_test_e2e
continue-on-error: true # when this fails, we still want to do some cleanup
Expand All @@ -115,7 +116,8 @@ jobs:

# add playwright-report to web3.storage
- name: add playwright-report to web3.storage
if: ${{ inputs.add_playwright_report_to_web3_storage }} && steps.check_website_playwright_report.outputs.files_exists == 'true'
# If the job wasn't triggered manually by a workflow_dispatch then we default the option to true:
if: (github.event_name != 'workflow_dispatch' || inputs.add_playwright_report_to_web3_storage) && steps.check_website_playwright_report.outputs.files_exists == 'true'
uses: web3-storage/add-to-web3@v2
id: add_playwright_report_to_web3_storage
with:
Expand Down Expand Up @@ -260,7 +262,7 @@ jobs:
if: (github.event_name == 'push' && github.ref == 'refs/heads/main' && needs.changelog.outputs.releases_created) || inputs.force_release
name: Release
runs-on: ubuntu-latest
environment:
environment:
name: production
url: https://web3.storage
needs:
Expand Down