Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CardShell: fix reticle position #352

Merged
merged 1 commit into from
Nov 23, 2023
Merged

CardShell: fix reticle position #352

merged 1 commit into from
Nov 23, 2023

Conversation

Tofee
Copy link
Member

@Tofee Tofee commented Nov 23, 2023

partial revert of 1505a29

@Herrie82
Copy link
Contributor

@Tofee Shouldn't we update the OrientationHelper.qml as well?

import QtQuick 2.9
import QtSensors 5.11

@Tofee
Copy link
Member Author

Tofee commented Nov 23, 2023

I'd prefer doing that for the whole project; most of our QML imports are quite outdated.

@Herrie82
Copy link
Contributor

OK we'll keep that for later. I understood from some comment on SFOS that we might be able to do without versioning altogether?sailfishos/fingerterm#6

@Herrie82 Herrie82 merged commit 994f96f into master Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants