Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDE-736] - NewMapComponent - As a user, I want the popups to close when I click outside of them #670

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kleysonr
Copy link
Contributor

No description provided.

var ph = this.placeholder('.map-container')[0];

var $src = $(event.srcElement);
var isChildOfMap = _.filter($src.parents(), function(node){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace with _.some

@carlosrusso
Copy link
Contributor

The commits lack the issue tag. Please squash the commits to a single commit and amend the message.

@buildguy

This comment has been minimized.

@buildguy

This comment has been minimized.

@buildguy

This comment has been minimized.

@buildguy

This comment has been minimized.

@buildguy
Copy link

buildguy commented May 1, 2023

❌ Build failed in 19s

Build command:

mvn clean verify -B -e -Daudit -amd

❗ No tests found!

Errors:

Filtered log (click to expand)

Pull request build was aborted: Source fork/repository no longer exists! Please consider closing it.

ℹ️ This is an automatic message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants