fix(workflow): dispatch new version also on new release event #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maloun96
commented
May 18, 2021
| @@ -17,6 +19,9 @@ jobs: | |||
| git checkout HEAD~1 | |||
| PREVIOUS_VERSION=$(node -p -e "require('./package.json').version") | |||
|
|
|||
| echo "Previous version: $PREVIOUS_VERSION" | |||
There was a problem hiding this comment.
Added this logs to see if it passed and the trigger happens
maloun96
force-pushed
the
release_workflow
branch
3 times, most recently
from
a243e39 to
dbca2da
Compare
maloun96
force-pushed
the
release_workflow
branch
from
dbca2da to
b98ad4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some investigation, the "chore" release does not trigger events (https://github.com/webex/components/actions/workflows/dispatch-new-version-event.yml) Here are the latest triggered events and there is no commit with "chore". This PR is going to fix it.