Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(WebexMember): split component into space members and meeting participant #772

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thescripted
Copy link
Contributor

@thescripted thescripted commented Mar 22, 2022

Separate WebexMember intoWebexMember for spaces and WebexMeetingParticipant for meetings
Separate WebexMemberRoster intoWebexMemberRoster for spaces and WebexMeetingRoster for meetings

SPARK-308491
SPARK-308492

@thescripted thescripted force-pushed the refactor/split-webex-member branch from 473bc67 to 78b320f Compare March 22, 2022 19:45
Copy link
Member

@taymoork2 taymoork2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thescripted thescripted force-pushed the refactor/split-webex-member branch 4 times, most recently from f1a0714 to 6991e6e Compare March 30, 2022 14:59
@thescripted thescripted force-pushed the refactor/split-webex-member branch from 6991e6e to 6827327 Compare March 30, 2022 18:32
@thescripted thescripted requested a review from taymoork2 March 31, 2022 18:44
@cipak
Copy link
Contributor

cipak commented Apr 27, 2022

Separate WebexMember intoWebexMember for spaces and WebexMeetingParticipant for meetings Separate WebexMemberRoster intoWebexMemberRoster for spaces and WebexMeetingRoster for meetings

SPARK-308491 SPARK-308492

This seems to introduce some code duplication, can this be avoided?

For example, leaving the generic WebexMember component as-is, and introducing two additional components:

  • WebexSpaceMember
  • WebexMeetingMember

These components would just use WebexMember with a hardcoded destination type, avoiding of duplication of js code and css:

function WebexSpaceMember(...) {
  return <WebexMember destinationType="ROOM" ... />;
}

Maybe the same could be done for the roster. I would suggest using the names WebexSpaceRoster and WebexMeetingRoster, so that the difference is clear: SpaceRoster vs MeetingRoster, instead of MemberRoster vs MeetingRoster which is a bit confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants