-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-widgets): snapshot test fix #1445
fix(react-widgets): snapshot test fix #1445
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the description with the list of tests done for reference in the future.
Also, looks like the unit tests and linting are failing. Could we check why this is happening.
Should we also make the browser tests optional as this needs to be completed in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please update the description of PR to say 'React version upgrade'.
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
REACT Version Upgrade
JIRA: https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-559078
Upgraded react, react-dom and react-test-renderer from 17.0.2 to 18.3.1 version as part of this PR.
Test 1: Selected 'To Space' as the destination and joined a space. Was able to message and join a meeting.
Test 2: Joined meeting using SIP URI as guest, tested password flow.