Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webex): upgrade webex to latest version #343

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

Parimala032
Copy link
Contributor

@Parimala032 Parimala032 commented Oct 21, 2024

Upgrade webex package version to the latest 2.x as this is causing errors on widgets while resolving webex versions across different packages.

Please do see this PR for more context that changes made in the file MeetingSDKAdapter.js

  • Previously it has been like name: options:name , now I am Assigning the options.name to the alias because the SDK options contain the parameter as the alias, not a name

@Parimala032 Parimala032 changed the title upgrade webex to latest version fix(webex): upgrade webex to latest version Oct 21, 2024
Copy link
Contributor

@mkesavan13 mkesavan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Won't this block instant connect? They use the widgets repo and react-widgets repo. Right?

@sreenara @Shreyas281299

@sreenara sreenara merged commit 29c5c27 into webex:master Oct 22, 2024
1 check failed
@sreenara
Copy link
Contributor

🎉 This PR is included in version 1.112.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Parimala032 pushed a commit to Parimala032/sdk-component-adapter that referenced this pull request Nov 8, 2024
## [1.112.12](webex/sdk-component-adapter@v1.112.11...v1.112.12) (2024-10-22)

### Bug Fixes

* **webex:** upgrade webex to latest version ([webex#343](webex#343)) ([29c5c27](webex@29c5c27))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants