Merge branch 'next' into antsukan/conditionally-add-device-permissions

webex · Sep 27, 2024 · ba5ed1b · ba5ed1b
2 parents db7bbcf + 0bf3d24
commit ba5ed1b
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 0 deletions.
diff --git a/packages/@webex/plugin-meetings/src/meeting/index.ts b/packages/@webex/plugin-meetings/src/meeting/index.ts
@@ -5232,6 +5232,9 @@ export default class Meeting extends StatelessWebexPlugin {
         this.meetingFiniteStateMachine.join();
         this.setupLocusMediaRequest();
 
+        // @ts-ignore
+        this.webex.internal.device.meetingStarted();
+
         LoggerProxy.logger.log('Meeting:index#join --> Success');
 
         Metrics.sendBehavioralMetric(BEHAVIORAL_METRICS.JOIN_SUCCESS, {

diff --git a/packages/@webex/plugin-meetings/src/meeting/util.ts b/packages/@webex/plugin-meetings/src/meeting/util.ts
@@ -170,6 +170,8 @@ const MeetingUtil = {
   },
 
   cleanUp: (meeting) => {
+    meeting.getWebexObject().internal.device.meetingEnded();
+
     meeting.breakouts.cleanUp();
     meeting.simultaneousInterpretation.cleanUp();
     meeting.locusMediaRequest = undefined;

diff --git a/packages/@webex/plugin-meetings/test/unit/spec/meeting/index.js b/packages/@webex/plugin-meetings/test/unit/spec/meeting/index.js
@@ -1605,6 +1605,7 @@ describe('plugin-meetings', () => {
             const result = await join;
 
             assert.calledOnce(MeetingUtil.joinMeeting);
+            assert.calledOnce(webex.internal.device.meetingStarted);
             assert.calledOnce(meeting.setLocus);
             assert.equal(result, joinMeetingResult);
             assert.calledWith(webex.internal.llm.on, 'online', meeting.handleLLMOnline);

diff --git a/packages/@webex/plugin-meetings/test/unit/spec/meeting/utils.js b/packages/@webex/plugin-meetings/test/unit/spec/meeting/utils.js
@@ -71,6 +71,7 @@ describe('plugin-meetings', () => {
         assert.calledOnce(meeting.updateLLMConnection);
         assert.calledOnce(meeting.breakouts.cleanUp);
         assert.calledOnce(meeting.simultaneousInterpretation.cleanUp);
+        assert.calledOnce(webex.internal.device.meetingEnded);
       });
 
       it('do clean up on meeting object with LLM disabled', async () => {
@@ -87,6 +88,7 @@ describe('plugin-meetings', () => {
         assert.notCalled(meeting.updateLLMConnection);
         assert.calledOnce(meeting.breakouts.cleanUp);
         assert.calledOnce(meeting.simultaneousInterpretation.cleanUp);
+        assert.calledOnce(webex.internal.device.meetingEnded);
       });
 
       it('do clean up on meeting object with no config', async () => {
@@ -102,6 +104,7 @@ describe('plugin-meetings', () => {
         assert.notCalled(meeting.updateLLMConnection);
         assert.calledOnce(meeting.breakouts.cleanUp);
         assert.calledOnce(meeting.simultaneousInterpretation.cleanUp);
+        assert.calledOnce(webex.internal.device.meetingEnded);
       });
     });
 

diff --git a/packages/@webex/test-helper-mock-webex/src/index.js b/packages/@webex/test-helper-mock-webex/src/index.js
@@ -268,6 +268,8 @@ function makeWebex(options) {
           get: sinon.stub(),
         },
       },
+      meetingEnded: sinon.stub(),
+      meetingStarted: sinon.stub(),
       registered: true,
       register: sinon.stub().returns(Promise.resolve()),
       ipNetworkDetector: {