Skip to content

Commit

Permalink
fix(calling): remove-event-dependency-on-call-buttons
Browse files Browse the repository at this point in the history
  • Loading branch information
ShreyasSharma28 committed Oct 13, 2023
1 parent c2a2175 commit de53c30
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
6 changes: 2 additions & 4 deletions docs/samples/calling/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -477,8 +477,8 @@ function createCall(e) {
const {destination} = createCallForm.elements;

console.log(destination.value);


makeCallBtn.disabled = true;
outboundEndElm.disabled = false
call = line.makeCall({
type: 'uri',
address: destination.value,
Expand All @@ -504,8 +504,6 @@ function createCall(e) {
call.on('established', (correlationId) => {
callDetailsElm.innerText = `${correlationId}: Call Established`;
transferElm.disabled = false;
outboundEndElm.disabled = false;
makeCallBtn.disabled = true;
});
call.on('disconnect', (correlationId) => {
callDetailsElm.innerText = `${correlationId}: Call Disconnected`;
Expand Down
6 changes: 3 additions & 3 deletions docs/samples/calling/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ <h2 class="collapsible">Authentication</h2>
require token with spark:calls_write scope.</p>
<button id="enableProduction" type="button" class="btn-code" onclick=changeEnv()>In Production</button><span class="text-color"> ( Click to change the environment )</span>
<input id="access-token" name="accessToken" placeholder="Access Token" value="" type="text" style="margin: 1rem 0 0.5rem 0;" required>
<button id="access-token-save" class="btn-code" type="submit">calling.init()</button>
<pre id="access-token-status">Not initialized</pre>
</div>

<fieldset>
Expand All @@ -47,7 +45,7 @@ <h2 class="collapsible">Authentication</h2>
<p class="text-color" style="margin-top: 0; padding: 0;">
Following options allow to set the type of registration, service domain (e.g. cisco.webex.com), server region (e.g. east) and the country (e.g. us).
<br><br>
<strong>Note:</strong> Please update these before <mark>calling.init()</mark> if want to use different values.
<strong>Note:</strong> Please update these before <mark>Initialize Calling</mark> if want to use different values.
</p>

<div class="u-mv">
Expand All @@ -61,6 +59,8 @@ <h2 class="collapsible">Authentication</h2>
<input id="region" name="region" value="Region" type="string">
<input id="country" name="country" value="Country" type="string">
</fieldset>
<button id="access-token-save" class="btn-code" type="submit">Initialize Calling</button>
<pre id="access-token-status">Not initialized</pre>
</fieldset>
</form>
<!-- authentication-registration -->
Expand Down

0 comments on commit de53c30

Please sign in to comment.