-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): changes in deploy cd to push docs folder changes to docu… #3088
chore(docs): changes in deploy cd to push docs folder changes to docu… #3088
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Perhaps we could add some test code into calling so after the merge, we can go to the samples page hosted on documentation
branch and ensure that the new calling.min.js
made it?
.github/workflows/deploy.yml
Outdated
- name: Publish Docs Folder | ||
run: | | ||
git add docs/ | ||
git commit -m "chore(docs): update docs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would add the versoin number if possible, Not sure if we want to do it here but only if webex package changes then only we need to deploy the documentation we could optimise it later too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not publishing the Webex package yet so we will add this later
7217a07
to
0d3cfec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Approving.
However, just curious what does github.actor
contain?
@mkesavan13, https://docs.github.com/en/actions/learn-github-actions/contexts |
COMPLETES #https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-455628
This pull request addresses
Added steps in the deploy CD pipeline to build the docs folder and push changes to the documentation branch after SDK deployment.
by making the following changes
Added GitHub action in deploy.yml file under .gihtub/worfflows folder for publishing of docs folder to the documentation branch.
Change Type
The following scenarios where tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.