feat(calling): adding metrics for bnr #3161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
sreenara
requested changes
Oct 31, 2023
sreenara
requested changes
Nov 3, 2023
| @@ -321,6 +321,43 @@ class MetricManager implements IMetricManager { | |||
| this.webex.internal.metrics.submitClientMetrics(name, data); | |||
| } | |||
| } | |||
|
|
|||
| public submitBNRMetric( | |||
There was a problem hiding this comment.
I don't see UT changes for this function?
Kesari3008
force-pushed
the
SPARK-466014-BNR-Metrics
branch
from
f0cc488 to
af3ee4f
Compare
|
Raised separate PR as this one was having merge conflicts due to beta to next merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES #https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-466014
This pull request addresses
Adding metrics to be sent when BNR is enabled/disabled on the call.
by making the following changes
Invoking submitBNRMetric() under dial() API, answer() API and outputTrackUpdateListener that listens for following events:
streamTrack.on("effect:added"
effect.on("enabled"
effect.on("disabled"
Based on the reception of above events track is updated if needed and BNR metrics are sent when the effect is enabled/disabled.
Change Type
The following scenarios where tested
Testcase 1: Enabled BNR and dialed an outbound call. BNR_ENABLED metrics are being sent once dial API is invoked. Disabled the BNR while on the call and BNR_DISABLED metrics are being sent for the same.
Testcase 2: Enabled BNR, triggered an inbound call and answered it. BNR_ENABLED metrics are being sent once answer API is invoked. Disabled the BNR while on the call and BNR_DISABLED metrics are being sent for the same.
Testcase 3: On an ongoing call, enabled and disabled BNR and metrics are sent for each occurrence.
Network logs are attached in the JIRA for each scenario mentioned above.
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.