-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(meetings): pass encrypted title based on APPI API for conversation #3166
Conversation
@arun3528, Tested locally, I will test this again once amplify preview link is generated. |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
@@ -151,7 +151,7 @@ export default class MeetingInfoV2 { | |||
}; | |||
|
|||
return this.webex | |||
.request(conversationUrl) | |||
.request(conversationUrl, {disableTransform: true}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice looks like it take the url and options separately also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes @arun3528, looks like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arun3528, should we have includeParticipants: true,
also, I don't think that is required, because it's working fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added screen recording after testing in amplify preview link.
cc - @arun3528
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the query string it should say includeParticipant , it might break in future so better add that and check the query string for the api call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/@webex/plugin-meetings/src/meeting-info/meeting-info-v2.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just one minor comment!
packages/@webex/plugin-meetings/src/meeting-info/meeting-info-v2.ts
Outdated
Show resolved
Hide resolved
packages/@webex/plugin-meetings/src/meeting-info/meeting-info-v2.ts
Outdated
Show resolved
Hide resolved
8eb0aef
to
0e592f1
Compare
d6e641a
to
62d4f85
Compare
pass encrypted title based on APPI API for conversation
62d4f85
to
df6abee
Compare
COMPLETES #SPARK-469170
This pull request addresses
Experiencing a failure when attempting to start an instant space meeting URL: https://co.webex.com/wbxappapi/v2/meetings/spaceInstant.
The error message received is '416 Range Not Satisfiable' with the response '416020' and message 'e2ee decrypt error.'
by making the following changes
should pass encrypted title based on APPI API ("/wbxappapi/v2/meetings/spaceInstant) Team.
Updated the code and tests for this.
Screen.Recording.2023-11-02.at.10.58.40.AM.mov
Change Type
The following scenarios where tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
Tested some basic manual flow and also attached the screen recording -
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.