Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meeting): added getPermissionTokenTimeLeft method #3193

Closed
wants to merge 835 commits into from

Conversation

cscheffauer
Copy link
Contributor

This pull request addresses

the issue of not knowing how much seconds are left till we reach permissionToken timeout

by making the following changes

  • Added getPermissionTokenTimeLeftInSec public method to return

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

  • Unit tested the function, to cover return values of:
    • undefined
    • positive value
    • negative value

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly

Webex Publisher and others added 30 commits July 19, 2023 17:20
marcin-bazyl and others added 27 commits October 30, 2023 10:52
@cscheffauer cscheffauer requested review from a team as code owners November 13, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.