test(metrics): revert jest changes for metrics and mercury plugins #3547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shreyas281299
added
the
validated
Shreyas281299
commented
Apr 22, 2024
| @@ -361,9 +361,9 @@ describe('plugin-metrics', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| //TODO: The following two skipped tests needs investigation: https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-485382 | |||
| //TODO: The following two skipped tests are failling when run using jest, needs investigation: https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-485382 | |||
There was a problem hiding this comment.
Removed it.
mkesavan13
approved these changes
Apr 22, 2024
sreenara
approved these changes
Apr 22, 2024
sreenara
changed the title
Shreyas281299
added a commit
to Shreyas281299/webex-js-sdk
that referenced
this pull request
Apr 22, 2024
…ebex#3547) Co-authored-by: Shreyas Sharma <[email protected]>
mkesavan13
pushed a commit
to arun3528/webex-js-sdk
that referenced
this pull request
Apr 22, 2024
…ebex#3547) Co-authored-by: Shreyas Sharma <[email protected]>
mkesavan13
pushed a commit
to arun3528/webex-js-sdk
that referenced
this pull request
Apr 29, 2024
…ebex#3547) Co-authored-by: Shreyas Sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES # SPARK-513491
Revert skipped test in plugin-metrics and plugin-mercury because those tests were failling when we run in jest. Since we have moved them back to mocha those tests are passing.
internal-plugin-presence, changes the test so that it can run in both jest and mocha. Easier to migrate to beta. We dont run these tests in next this is solely for the migration process.
Testing
Made the same changes in beta branch and all tests are passing there. Plugin-metric and plugin-mercury tests are passing in next as well as beta
Change Type
The following scenarios where tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.