Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(internal-plugin-metrics): remove unwanted skip #3552

Closed
wants to merge 1 commit into from

Conversation

mkesavan13
Copy link
Contributor

@mkesavan13 mkesavan13 commented Apr 22, 2024

COMPLETES AdHoc

This pull request addresses

The skipped tests that we had in the next branch was because they were failing and Catalin needed more time to figure it out. Now that we've moved internal-plugin-metrics to run tests on Mocha itself, we do not have to skip these tests anymore.

by making the following changes

We've removed the skips and ran these tests locally to see them pass.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@mkesavan13 mkesavan13 requested a review from a team as a code owner April 22, 2024 07:28
@mkesavan13 mkesavan13 added the validated If the pull request is validated for automation. label Apr 22, 2024
@mkesavan13 mkesavan13 closed this Apr 22, 2024
@mkesavan13 mkesavan13 deleted the remove-metrics-skips branch April 22, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant