Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(samples): fix vbg and bnr working in int env #3576

Merged
merged 2 commits into from
May 2, 2024

Conversation

rarajes2
Copy link
Contributor

@rarajes2 rarajes2 commented Apr 29, 2024

COMPLETES #< SPARK-515143 >

This pull request addresses

Background blur and background noise reduction doesn't work in the integration environment.

by making the following changes

VBG and BNR works in the integration environment on the samples page.

int-env-vbg.mov

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

Tested the following scenarios manually:

  • Working of VBG and BNR effects in integration environment on samples page

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@rarajes2 rarajes2 requested a review from a team as a code owner April 29, 2024 11:52
@rarajes2 rarajes2 added the validated If the pull request is validated for automation. label Apr 29, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3576.d3m3l2kee0btzx.amplifyapp.com

@Kesari3008
Copy link
Contributor

@rarajes2 Could you please take a screenshare for the VBG scenario test and upload it in the test performed section in description? And mention testcases there too

@sreenara sreenara merged commit 5254bd8 into webex:next May 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants