Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal-plugin-metrics): add callingServiceType to MQE #3593

Merged
merged 6 commits into from
Jun 12, 2024

Conversation

SomeBody16
Copy link
Contributor

@SomeBody16 SomeBody16 commented May 10, 2024

COMPLETES SPARK-510208

This pull request addresses

Missing callingServiceType in MQE which is always LOCUS for webex-js-sdk

It's a follow to PR #3569 (previously to beta branch)

by making the following changes

Adds callingServiceType to MQE

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@SomeBody16 SomeBody16 requested a review from a team as a code owner May 10, 2024 12:26
@SomeBody16 SomeBody16 changed the title feat(plugin-meetings): callingServiceType stat fix(plugin-meetings): callingServiceType stat May 10, 2024
@SomeBody16 SomeBody16 changed the title fix(plugin-meetings): callingServiceType stat fix(plugin-meetings): add callingServiceType to MQE May 10, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3593.d3m3l2kee0btzx.amplifyapp.com

@arun3528 arun3528 added the validated If the pull request is validated for automation. label May 13, 2024
@SomeBody16 SomeBody16 force-pushed the SPARK-510208 branch 2 times, most recently from 5d7d8be to eb7263e Compare May 21, 2024 09:14
@SomeBody16 SomeBody16 self-assigned this May 29, 2024
@SomeBody16 SomeBody16 force-pushed the SPARK-510208 branch 3 times, most recently from 2004534 to 32e9b23 Compare June 10, 2024 11:48
@SomeBody16 SomeBody16 requested a review from brycetham June 10, 2024 12:28
@SomeBody16 SomeBody16 requested a review from a team as a code owner June 11, 2024 10:20
Copy link
Contributor

@brycetham brycetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Can you update your PR title to the correct plugin?

@SomeBody16 SomeBody16 changed the title fix(plugin-meetings): add callingServiceType to MQE fix(internal-plugin-metrics): add callingServiceType to MQE Jun 11, 2024
@SomeBody16 SomeBody16 merged commit 08707cf into webex:next Jun 12, 2024
11 checks passed
@SomeBody16 SomeBody16 deleted the SPARK-510208 branch June 12, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants