-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-meetings): streamline is active speaker mqa #3597
Conversation
e3f0854
to
24b5976
Compare
This pull request is automatically being deployed by Amplify Hosting (learn more). |
ba8c016
to
67ca6db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Please add validated tag and ensure the CI passes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
# Conflicts: # packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Had a small suggestion but we don't have to do it in this PR.
@edvujic thanks for finishing PR! |
COMPLETES WEBEX-379504
This pull request addresses
An issue where the isActiveSpeaker property is erroneously set to true within the MQE, regardless of the actual speaker status.
Change Type
The following scenarios where tested
Changes:
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly