Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-meetings): streamline is active speaker mqa #3597

Merged
merged 9 commits into from
Jul 5, 2024

Conversation

edvujic
Copy link
Contributor

@edvujic edvujic commented May 13, 2024

COMPLETES WEBEX-379504

This pull request addresses

An issue where the isActiveSpeaker property is erroneously set to true within the MQE, regardless of the actual speaker status.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

Changes:

  • Ensured isActiveSpeaker MQA is accurately propagated from WCME.
  • Updated JS-SDK to check and mark activeSpeaker MQA as true only if active in the previous interval.

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly

@edvujic edvujic requested a review from a team as a code owner May 13, 2024 10:33
@edvujic edvujic force-pushed the is-active-speaker-mqa branch from e3f0854 to 24b5976 Compare May 13, 2024 10:35
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3597.d3m3l2kee0btzx.amplifyapp.com

@SomeBody16 SomeBody16 changed the title fix(plugin-meeting): streamline is active speaker mqa fix(plugin-meetings): streamline is active speaker mqa May 14, 2024
@edvujic edvujic force-pushed the is-active-speaker-mqa branch from ba8c016 to 67ca6db Compare May 23, 2024 16:44
Copy link
Contributor

@mkesavan13 mkesavan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please add validated tag and ensure the CI passes

@edvujic edvujic self-assigned this May 24, 2024
@edvujic edvujic added the validated If the pull request is validated for automation. label May 24, 2024
@edvujic edvujic requested a review from a team as a code owner July 3, 2024 12:12
Copy link
Contributor

@SomeBody16 SomeBody16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

evujici added 2 commits July 4, 2024 16:47
# Conflicts:
#	packages/@webex/plugin-meetings/test/unit/spec/stats-analyzer/index.js
Copy link
Contributor

@brycetham brycetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Had a small suggestion but we don't have to do it in this PR.

@edvujic edvujic merged commit 7ccbeca into webex:next Jul 5, 2024
11 checks passed
@antsukanova
Copy link
Contributor

@edvujic thanks for finishing PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants