Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-meetings): fix check for whether domain is exempted #3600

Merged
merged 7 commits into from
May 15, 2024

Conversation

sreenara
Copy link
Contributor

@sreenara sreenara commented May 14, 2024

COMPLETES # SPARK-525193

This pull request addresses

the issue in current logic of recognizing an exempted domain while populating the Direct Meeting Information. The current logic doesn't recognize that meet-intb.ciscospark.com is still part of the domain ciscospark.com. #2329

Due to the above issue in the logic, we see a problem on Webex Instant Connect during the consultation. Currently, the meeting information is unavailable for the application.

The getDirectMeetingInfoURI function does not use the catalog to populate the URI for fetching the meeting information. It simply tries to validate from an allow list of known domains and appends /wbxappapi/meetingInfo to the URL.
In the Instant Connect, this results in the application sending out a GET https://meet.ciscospark.com/wbxappapi/v1/meetingInfo or GET https://meet-intb.ciscospark.com/wbxappapi/v1/meetingInfo to fetch the meeting information.

Both of the above URLs are incorrect and not present in the catalog. Therefore, this breaks the meeting information in Instant Connect.

by making the following changes

Change the logic to correctly check for a substring so subdomains under the exempted domain array are also covered.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

  1. Try webex.meetings.create('[email protected]') using an INT token from Instant Connect in our Kitchen Sink and ensure that the meetingInfo object is correctly populated.
  2. Try to generate guest token in Kitchen Sink app and do a webex.meetings.create() for a production webex meeting.

Logs and HAR files for working and non-working scenarios:
meetingInfo-issue-fix.zip

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@sreenara sreenara added the validated If the pull request is validated for automation. label May 14, 2024
@sreenara sreenara requested a review from a team as a code owner May 14, 2024 17:44
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3600.d3m3l2kee0btzx.amplifyapp.com

@sreenara sreenara requested review from chburket and arun3528 May 14, 2024 18:29
@sreenara sreenara removed request for arun3528 and chburket May 15, 2024 06:08
Copy link
Contributor

@chburket chburket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sreenara sreenara merged commit 4438dde into webex:next May 15, 2024
11 checks passed
@sreenara sreenara deleted the fix-meetinginfo-pop branch May 15, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants