fix(plugin-meetings): fix check for whether domain is exempted #3600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES # SPARK-525193
This pull request addresses
the issue in current logic of recognizing an exempted domain while populating the Direct Meeting Information. The current logic doesn't recognize that
meet-intb.ciscospark.com
is still part of the domainciscospark.com
. #2329Due to the above issue in the logic, we see a problem on Webex Instant Connect during the consultation. Currently, the meeting information is unavailable for the application.
The
getDirectMeetingInfoURI
function does not use the catalog to populate the URI for fetching the meeting information. It simply tries to validate from an allow list of known domains and appends /wbxappapi/meetingInfo to the URL.In the Instant Connect, this results in the application sending out a
GET https://meet.ciscospark.com/wbxappapi/v1/meetingInfo
orGET https://meet-intb.ciscospark.com/wbxappapi/v1/meetingInfo
to fetch the meeting information.Both of the above URLs are incorrect and not present in the catalog. Therefore, this breaks the meeting information in Instant Connect.
by making the following changes
Change the logic to correctly check for a substring so subdomains under the exempted domain array are also covered.
Change Type
The following scenarios where tested
webex.meetings.create('[email protected]')
using an INT token from Instant Connect in our Kitchen Sink and ensure that themeetingInfo
object is correctly populated.webex.meetings.create()
for a production webex meeting.Logs and HAR files for working and non-working scenarios:
meetingInfo-issue-fix.zip
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.