Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contacts): import dss plugin for search and cloud contact resolution #3618

Merged
merged 1 commit into from
May 27, 2024

Conversation

sreenara
Copy link
Contributor

@sreenara sreenara commented May 26, 2024

COMPLETES #NA

This pull request addresses

calling plugin missing dss plugin import due to which we can't utilize dss functions in the calling code.

by making the following changes

requiring the @webex/internal-plugin-dss in calling.js

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

  1. Check the presence of the webex.internal.dss object.
  2. Run a test to lookup a user by doing contacts.webex.internal.dss.lookup({id: userId});
  3. Test other calling functionality like making calls.

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@sreenara sreenara added the validated If the pull request is validated for automation. label May 26, 2024
@sreenara sreenara marked this pull request as ready for review May 27, 2024 03:23
@sreenara sreenara requested a review from a team as a code owner May 27, 2024 03:23
@sreenara sreenara merged commit 3971a43 into webex:next May 27, 2024
9 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants